typescript typings #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I believe the CI build failure is related to a dependency of coveralls using versioning syntax unsupported by npm 1.2.30. I think it's the |
|
Can this be accepted anyway? |
emn178
reviewed
Jul 21, 2017
| @@ -25,5 +25,6 @@ | |||
| "homepage": "https://github.com/emn178/hi-base32", | |||
| "bugs": { | |||
| "url": "https://github.com/emn178/hi-base32/issues" | |||
| } | |||
| }, | |||
| "typings": "./hi-base32.d.ts" | |||
There was a problem hiding this comment.
Rename file to index.d.ts, TypeScript looks up this path in default.
And look like document also uses types in default.
|
sorry, didn't notice this. |
|
add this feature in v0.3.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows people to seamlessly access the library from TypeScript.