Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

more safe write #3

Closed
wants to merge 1 commit into from
Closed

more safe write #3

wants to merge 1 commit into from

Conversation

fynn90
Copy link

@fynn90 fynn90 commented Jul 20, 2016

when use uglify,this will replace undefined.

@Fatefan
more safe write
2be94a1 
when use uglify,this will replace undefined.
@coveralls
Copy link

coveralls commented Jul 20, 2016 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 2be94a1 on fatefan:master into 5fcee84 on emn178:master.

@emn178
Copy link
Owner

emn178 commented Jul 21, 2016

What's the problem you want to fix?
Could you describe more?

@fynn90
Copy link
Author

fynn90 commented Jul 22, 2016

I use 'uglify' compression my JS file,then I find

(function () {}(this))

'this' will be replaced 'undefined'.

@emn178
Copy link
Owner

emn178 commented Jul 25, 2016

I can not reproduce your problem. What's uglify version you use?

@emn178 emn178 closed this Nov 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@fynn90 @coveralls @emn178 @Fatefan