Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enabling "build automatically" should be in a finally block #34

Closed
anthonyanjorin opened this issue Feb 21, 2018 · 4 comments
Closed
Assignees

Comments

@anthonyanjorin
Copy link
Contributor

To reproduce:

  • Choose a set of projects to build (code generation)
  • One of these projects should cause an exception to be thrown (.ecore missing, or properties file corrupt, etc)
  • build automatically is switched off at the beginning of the process, but apparently is not switched back on if an exception flies

My only explanation is that switching build automatically back on must be in a try block whereas it should actually be in the finally block to ensure that it is always executed.

@RolandKluge
Copy link
Contributor

Can you provide me with the exact code location?

@anthonyanjorin
Copy link
Contributor Author

If I could I would have fixed it myself :) I'm just guessing what the problem could be.

@RolandKluge
Copy link
Contributor

I am currently not able to reproduce this. Do you have a sample project for me?

  • If I rename moflon.properties.xmi, it is recreated.
  • If the .ecore file is missing, nothing happens at all.

As far as I know, the JDT may also switch off autobuild if it thinks that an infinite build circle may arise.

Also, as far as I know, eMoflon Core only manipulates the autobuild behavior via this class, which is only used by the WorkspaceInstaller: org.moflon.core.build.TaskUtilities .

@RolandKluge
Copy link
Contributor

I close this issue for now.

Let's reopen it, if there is a concrete project for reproduction

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants