Extract rather than inline styles in Global component when in compat mode #1443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset is good to goLatest commit: cdef1fa We got this. Not sure what this means? Click here to learn what changesets are. |
Codecov Report
|
|
To understand the PR I was taking a look at what emotion/packages/cache/src/index.js Lines 161 to 163 in 801727b |
|
Yep, that comment is wrong, updated it. |
emmatown
deleted the
extract-rather-than-inline-styles-in-global-component
branch
|
Thanks @mitchellhamilton. |
louisgv
pushed a commit
to louisgv/emotion
that referenced
this pull request
Sep 6, 2020
…mode (emotion-js#1443) * Extract rather than inline styles in Global component when in compat mode * Add a changeset * Update a comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Extract rather than inline styles in Global component when in compat mode
Why:
Closes #1424
How:
Checklist: