Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class not being applied when putting nil as css prop value on wrapper component #1530

Merged
merged 2 commits into from
Oct 2, 2019
Merged

Fix class not being applied when putting nil as css prop value on wrapper component #1530

merged 2 commits into from
Oct 2, 2019

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Oct 2, 2019 •
edited
Loading

fixes #1529

Checklist:

  • Documentation
  • Tests
  • Code complete
  • Changeset

@Andarist Andarist requested a review from emmatown October 2, 2019 22:08
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2019 •
edited
Loading

🦋 Changeset is good to go

Latest commit: aea78a8

We got this.

Not sure what this means? Click here to learn what changesets are.

@Andarist Andarist mentioned this pull request Oct 2, 2019
Closed
emmatown
emmatown approved these changes Oct 2, 2019
View reviewed changes
Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@codecov
Copy link

codecov bot commented Oct 2, 2019 •
edited
Loading

Codecov Report

Merging #1530 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/core/src/jsx.js 100% <100%> (ø) ⬆️

@emmatown emmatown merged commit 38bb2b1 into master Oct 2, 2019
@emmatown emmatown deleted the fix/1529 branch October 2, 2019 22:20
@github-actions github-actions bot mentioned this pull request Oct 2, 2019
Merged
ifiokjr added a commit to remirror/remirror that referenced this pull request Oct 6, 2019
@ifiokjr
fix: remove css prop when withoutEmotion is true
f8ca572 
Breaking tests caused by emotion-js/emotion#1530
ifiokjr added a commit to remirror/remirror that referenced this pull request Oct 7, 2019
@ifiokjr
fix: remove css prop when withoutEmotion is true
d24226a 
Breaking tests caused by emotion-js/emotion#1530
@snyk-bot snyk-bot mentioned this pull request Oct 16, 2019
Merged
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
@Andarist @emmatown
Fix class not being applied when putting nil as css prop value on wra…
3b2b68a 
…pper component (emotion-js#1530)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmatown emmatown emmatown approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Passing undefined to css prop breaks composition, no EmotionCssPropInternal inserted
2 participants
@Andarist @emmatown