Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing /* #__PURE__ */ annotation to creation of EmotionCssPropInternal #1537

Merged
merged 2 commits into from
Oct 5, 2019

Conversation

Andarist
Copy link
Member

@Andarist Andarist commented Oct 5, 2019

We could automate adding those with my https://github.com/Andarist/babel-plugin-annotate-pure-calls - but not sure how do you feel about it, so I've added this inline for now.

@changeset-bot
Copy link

changeset-bot bot commented Oct 5, 2019

🦋 Changeset is good to go

Latest commit: 049913c

We got this.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Oct 5, 2019

Codecov Report

Merging #1537 into master will not change coverage.
The diff coverage is 100%.

Impacted Files Coverage Δ
packages/core/src/jsx.js 100% <100%> (ø) ⬆️

Copy link
Member

@emmatown emmatown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@emmatown
Copy link
Member

emmatown commented Oct 5, 2019

We could automate adding those with my https://github.com/Andarist/babel-plugin-annotate-pure-calls - but not sure how do you feel about it, so I've added this inline for now.

I'd rather add them manually just in case things break

@emmatown emmatown merged commit 7855db4 into master Oct 5, 2019
@emmatown emmatown deleted the add-missing-pure-annotation branch October 5, 2019 11:00
@github-actions github-actions bot mentioned this pull request Oct 5, 2019
louisgv pushed a commit to louisgv/emotion that referenced this pull request Sep 6, 2020
…nternal (emotion-js#1537)

* Add missing /* #__PURE__ */ annotation to creation of EmotionCssPropInternal

* Update changes.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants