-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade Babel-related deps #1621
Conversation
💥 No ChangesetLatest commit: 84910f9 Merging this PR will not cause any packages to be released. If these changes should not cause updates to packages in this repo, this is fine 🙂 If these changes should be published to npm, you need to add a changeset. Click here to learn what changesets are, and how to add one. Click here if you're a maintainer who wants to add a changeset to this PR |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 84910f9:
|
require.resolve('@babel/plugin-transform-runtime'), | ||
[ | ||
require.resolve('@babel/plugin-transform-runtime'), | ||
{ version: require('@babel/runtime/package.json').version } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this allows inserting references to @babel/runtime
for helpers which were not available yet in 7.0.0-beta.0 release
@@ -11,8 +11,10 @@ module.exports = () => { | |||
require.resolve('babel-plugin-fix-dce-for-classes-with-statics'), | |||
require.resolve('@babel/plugin-transform-flow-strip-types'), | |||
require.resolve('babel-plugin-codegen'), | |||
require.resolve('@babel/plugin-proposal-object-rest-spread'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this was not using loose, I've removed it because it's already included nowadays in @babel/preset-env
which in turn uses loose
here, so it saves few bytes because we don't duplicate objectSpread2
helper across 2 packages (they were bundled in as it was a new helper) and we just reuse regular extends
helper
5b60430
to
84910f9
Compare
I don't think this deserves a changeset, it changes the dist files a little bit - but it's a micro optimization.
closes #1614