Get rid of NoElement component and useNoElementRender composable #1583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…avour of render functions
…Element component in favour of NoAnimation component
victorcg88
approved these changes
Aug 5, 2024
packages/x-components/src/x-modules/extra-params/components/renderless-extra-param.vue
Outdated
Show resolved
Hide resolved
packages/x-components/src/components/animations/no-animation.vue
Outdated
Show resolved
Hide resolved
diegopf
reviewed
Aug 5, 2024
| the component itself. It is the alternative for the NoElement antipattern. */ | ||
| const innerProps = { closeModal }; | ||
| return ( | ||
| slots.closingElement ? () => slots.closingElement?.(innerProps)[0] : innerProps |
There was a problem hiding this comment.
Previously we were using the slot name as kebab case and I think we should keep doing the same here to not introduce an additional breaking change. So I'd refactor it to slots['closing-element']
There was a problem hiding this comment.
I could have sworn I tried it in kebab-case but for some reason/error, I finally chose this way.
Now, I have tried in kebab-case and everything works, so consider it refactored together with openingElement.
…o get-rid-of-no-element-component
diegopf
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v-bind="$attrs"andinheritAttrs: falsein components when it is not the root nodeNoElementcomponent anduseNoElementRendercomposable in favour of Vue3 way for inheritance. No longer available to use them in components or templates.NoAnimationas alternative forNoElementwith the aim of using it as default value inanimationprops.Note: With this PR, no more warnings pending, except 2 from
xBusfrominfiniteScrolldirective fixed here #1584