fix: Snippet config extra params reactivity #1628
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request template
This PR checks if the extra params object has really changed to avoid unnecessary event emissions.
Motivation and context
In some customers, when a snippetConfig callback is executed,
ExtraParamsProvided
andExtraParamsChanged
events are fired even if they have not changed (and, as a consequence all the rest of the chained events that react to ExtraParamsChanged event emission).Type of change
What is the destination branch of this PR?
Main
How has this been tested?
An open PR can be used to see the implementation when a callback is executed & check:
extraParams
object has not changedTests performed according to testing guidelines:
Checklist: