Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

non-portable shebang in get-msquic.sh #67

Closed
datafoo opened this issue Dec 27, 2021 · 3 comments
Closed

non-portable shebang in get-msquic.sh #67

datafoo opened this issue Dec 27, 2021 · 3 comments

Comments

@datafoo
Copy link

datafoo commented Dec 27, 2021

I trying to use emqx/emqtt 1.4.5 in an Elixir project. While compiling, an error is reported about emqx/quic:

[nix-shell:~/myproject]$ mix compile
sh: /home/myuser/myproject/deps/quicer/get-msquic.sh: /bin/bash: bad interpreter: No such file or directory
sh: line 1: /home/myuser/myproject/deps/quicer/get-msquic.sh: Success
===> Hook for compile failed!

** (Mix) Could not compile dependency :quicer, "/home/myuser/.mix/rebar3 bare compile --paths /home/myuser/myproject/_build/dev/lib/*/ebin" command failed. Errors may have been logged above. You can recompile this dependency with "mix deps.compile quicer", update it with "mix deps.update quicer" or clean it with "mix deps.clean quicer"

I am using NixOS so /bin/bash does not exists.

The shebang #!/usr/bin/env bash would make the get-msquic.sh script more portable.

@zmstone
Copy link
Member

zmstone commented Dec 27, 2021

@datafoo thank you for reporting it.
#68

@qzhuyan qzhuyan closed this as completed Jan 3, 2022
@datafoo
Copy link
Author

datafoo commented Jan 12, 2022

When do you intend to release a new version with the fix? And a corresponding new version of emqx/emqtt as well?

@zmstone
Copy link
Member

zmstone commented Jan 12, 2022

When do you intend to release a new version with the fix? And a corresponding new version of emqx/emqtt as well?

@qzhuyan when will we be able to cut a new release of quic ?
the next EMQ X release (beta.4) will be release in March.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants