This repository has been archived by the owner on Dec 21, 2022. It is now read-only.
Cannot add new entry with if a hostname is a substring of an existing entry's hostname #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of an existing entry's hostname, the former is not added because storm thinks it exists already
emre
added a commit
that referenced
this pull request
Apr 30, 2014
Cannot add new entry with if a hostname is a substring of an existing entry's hostname
|
sorry for the late response, bumped as version 0.6.3. thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created this bug and here is a patch for it as well as a unit test. When an entry is added with a hostname that is a substring of an existing entry's hostname, the former is not added because storm thinks it exists already.
For example:
$ storm list listing entries: google-01 -> vagrant@google.com:24 google-02 -> vagrant@google.com:22 $ storm add goog vagrant@google.com error goog is already in your sshconfig. use storm edit command to modify.