Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify additional js files #8773

Closed
VirtualTim opened this issue Jun 10, 2019 · 6 comments
Closed

Minify additional js files #8773

VirtualTim opened this issue Jun 10, 2019 · 6 comments
Labels

Comments

@VirtualTim
Copy link
Collaborator

Additional js files generated by the compiler do not get minified. They probably should be.
For example Module.worker.js is generated when compiling with PTHREADS, Module.fetch.js when compiling with FETCH. These files are only ~11KB and ~115KB, but I can't see any harm on running the minifier on them.

@blockspacer
Copy link

1 Minify step can make debugging harder.
2 App developers can minify resulting files as they want.

If you want to add minify step - please make it optional (even better - using flag with ability to switch minify method)

@VirtualTim
Copy link
Collaborator Author

Well, yeah, I figured that this would obey the existing minification flags. Currently if you compile with something like -O3 then Module.js is minified, but those other files are not.

@kripken
Copy link
Member

kripken commented Jun 10, 2019

I agree, it makes sense to do this with the current flags (-g1 to preserve whitespace, etc.).

To minify those files, running Building.js_optimizer_no_asmjs with no passes should be enough, I think.

@stale
Copy link

stale bot commented Jun 9, 2020

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 7 days. Feel free to re-open at any time if this issue is still relevant.

@stale stale bot added the wontfix label Jun 9, 2020
@VirtualTim
Copy link
Collaborator Author

worker.js is now minified, but I don't' believe that fetch.js is.
Not a big deal, but would still be nice.

@stale stale bot removed the wontfix label Jun 10, 2020
@stale
Copy link

stale bot commented Jun 11, 2021

This issue has been automatically marked as stale because there has been no activity in the past year. It will be closed automatically if no further activity occurs in the next 30 days. Feel free to re-open at any time if this issue is still relevant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants