Update igraph and fix build #589
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* genlib_writer * netlist_simulator_controller * resynthesis * simulator
xiota
requested review from
SimonKlx,
nils1603,
SJulianS,
joern274 and
swallat
as code owners
|
Thank you for these updates. |
|
Thanks for the contribution! We may want to reconsider the choice for which plugins to build by default; your proposed change in 98a8e06 would cause the build to include the entire simulator toolchain by default, which comes with a bunch of dependency concerns. See my comment here: #588 (comment) @SJulianS: any reservations against bumping igraph to 0.10.13? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes problems preventing build on Arch Linux. Closes #588