Use kwargs for settings
#85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
prisae
added a commit
that referenced
this pull request
Apr 29, 2020
- Remove Python 3.5 from testing. - Remove deprecated functions. - Use f-strings for printing. * Replace numexpr by numba (#77) * Shorten runtime of examples * Deg/Unwrap/Lag => closes #76 (#78) * f-strings: fix existing and implement forgotten (#80) * Change `htarg`/`ftarg` to dicts internally (#81) * Always assume isotropy for {e;m}perm by default * Rename `transform.get_spline_values` -> `transform.get_dlf_points` * Undo #26 for consistency reasons * Documentation (#82) * Ensure src/rec are not altered (#83) * Renaming (#84) * Renaming all Hankel- and Fourier-routines * `factAng` -> `ang_fact` * `{fht;qwe;quad}arg{s}` -> `htarg` * `{qwe}arg{s}` -> `ftarg` * Closes #13 * Use `kwargs` for settings (#85) * All settings (`xdirect`, `ht`, `htarg`, `ft`, `ftarg`, `loop`, `verb`) are now extracted from `kwargs`. This makes it possible that all model-functions take the same keyword-arguments; warnings are raised if a particular parameter is not used in this function, but it doesn't fail (it fails, however, for unknown parameters). Pure positional calls including those parameters will therefore not work any longer. Closes #14 * Adjust manual and docstrings, intersphinx (#86) * EMArray: .amp and .pha are now methods (#87) * Fix dlf if 'fht' provided (#88) * Replace outer by broadcasting * htarg and ftarg MUST be dicts (#89) * Only one possibility for each method of `ht` and `ft` * Undo #7a9437ca * Reduce top namespace (#91)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All settings (
xdirect,ht,htarg,ft,ftarg,loop,verb) are now extracted fromkwargs. This makes it possible that allmodel-functions take the same keyword-arguments; warnings are raised if a particular parameter is not used in this function, but it doesn't fail (it fails, however, for unknown parameters). Pure positional calls including those parameters will therefore not work any longer.