Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable specify second level domain #2

Merged
merged 2 commits into from
Jun 22, 2018
Merged

Conversation

sakihet
Copy link
Contributor

@sakihet sakihet commented Jun 20, 2018

thank you for awesome gem.
i'd like to use backlog_kit on *.backlogtool.com spaces.

what do you think?

example:

client = BacklogKit::Client.new(
  space_id: '***',
  second_level_domain: 'backlogtool',
  top_level_domain: 'com',
)

@codecov-io
Copy link

Codecov Report

Merging #2 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master     #2   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          24     24           
  Lines         540    541    +1     
=====================================
+ Hits          540    541    +1
Impacted Files Coverage Δ
lib/backlog_kit/client.rb 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14124aa...108fce5. Read the comment docs.

@emsk
Copy link
Owner

emsk commented Jun 22, 2018

@sakihet I think it's a useful API for developers who use backlogtool.com spaces.
Thank you for your PR 😄

@emsk emsk merged commit ccb3cb3 into emsk:master Jun 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants