Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile-fix for when CSS_PARSER is not defined #124

Merged
merged 1 commit into from
Feb 23, 2018
Merged

Conversation

frodegill
Copy link
Contributor

One of my machines (2GB RAM, no swap) runs out of memory compiling CssParser.C. For Wt3 I could undefine CSS_PARSER in that file and compile a working library. For Wt4, I get a compile error (seems like someone forgot to upgrade this part of the code). Provided is a compile-fix.

@emweb
Copy link
Collaborator

emweb commented Feb 23, 2018

We indeed did not test if it compiled with CSS_PARSER not defined. It's a hidden feature anyway, one of which I wasn't if sure we need it anymore. It's indeed a file that requires a lot of memory to compile, though. I didn't think people were still trying to compile C++ code on machines with 2 GiB RAM and no swap.

I'll take a look at this PR, but I don't know if our intention is to really keep supporting that unless it's really necessary to get it to compile for certain platforms.

Regards,
Roel

@emweb emweb merged commit ca2fa88 into emweb:master Feb 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants