Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 500 status leading to invalid HTTP reply [master] #132

Merged
merged 1 commit into from
Jun 6, 2018
Merged

Fix 500 status leading to invalid HTTP reply [master] #132

merged 1 commit into from
Jun 6, 2018

Conversation

rgoupil
Copy link
Contributor

@rgoupil rgoupil commented Jun 6, 2018

A missing break was breaking the HTTP reply by inserting two status lines instead of only one

A missing break was breaking the HTML reply by inserting two status lines instead of only one
@rgoupil rgoupil changed the title Fix 500 status leading to invalid HTML reply Fix 500 status leading to invalid HTML reply [master] Jun 6, 2018
@rgoupil
Copy link
Contributor Author

rgoupil commented Jun 6, 2018

FYI, here is the faulty commit: 0fe2d3a, introduced in 3.3.5

@emweb emweb merged commit 579842d into emweb:master Jun 6, 2018
@rgoupil rgoupil deleted the patch-1 branch June 6, 2018 08:19
@rgoupil rgoupil changed the title Fix 500 status leading to invalid HTML reply [master] Fix 500 status leading to invalid HTTP reply [master] Jun 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants