Do not write to std::cerr when opening log file successfully #157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since we have opened the file successfully, it seems there isn't a lot of value in logging, and in particular logging to std::err. The logic is detailed more clearly in this ticket [1]. [1] https://redmine.emweb.be/issues/7240
|
I don't think we can merge this just like that. We tend to find it rather useful that the output file is printed when Wt is started. Regards, |
|
As discussed in the ticket, I understand that you have a lot more to worry about than my use case, so I'll close the ticket. Thanks for your time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we have opened the file successfully, it seems there isn't a lot of value in logging, and in particular logging to std::err. The logic is detailed more clearly in this ticket [1].
[1] https://redmine.emweb.be/issues/7240