WMatchValidator support... #29
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… without deleting the old one.
|
Unsure if we want to merge this, on the one hand it there is nothing wrong with the implementation, but on the other hand it's not very general purpose and could as well exist outside the library. Perhaps we need a place to collect goodies like these outside the main library. |
|
Maybe my library wt-classes is good place for such things? |
|
While there may be some value to a WMatchValidator, I'm closing this PR since it is no longer compatible with Wt 4. Regards, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Koen,
Please review the code and accept this pull request for WMatchValidator support in Wt. A Match Validator matches two text fields. One of the use-cases for this validator is to compare two password fields during user account registration.
Kind regards,
~Plug