Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial HVAC view #8

Merged
merged 6 commits into from
Sep 6, 2018
Merged

Add initial HVAC view #8

merged 6 commits into from
Sep 6, 2018

Conversation

ryanjduffy
Copy link
Contributor

@ryanjduffy ryanjduffy commented Aug 31, 2018

Related Issue: #6

  • Adds basic layout for HVAC Screen
  • Uses SliderButton rather than adding a slider but we can harvest that as well if desired

Needs:

  • Picker component for temp control
  • Icons for buttons. Might convert them to Button instead of LabeledIconButton once the icons are meaningful
  • Add custom component for heated seat control. AGL version is tri-mode -- off, low, high
  • Some behaviors applied (e.g. selecting Auto might disable the fan slider and fan selector icon buttons)

image

Ryan Duffy and others added 6 commits August 31, 2018 13:15
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
Copy link
Member

@teckliew teckliew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@teckliew
Copy link
Member

teckliew commented Sep 6, 2018

Could add in ToggleButton's later once we have that up.

@ryanjduffy ryanjduffy merged commit 9006516 into master Sep 6, 2018
@ryanjduffy ryanjduffy deleted the feature/hvac branch September 6, 2018 15:59
sugardave pushed a commit that referenced this pull request Sep 6, 2018
commit b7d6b90
Author: Derek Tor <derek.tor@lge.com>
Date:   Thu Sep 6 11:36:57 2018 -0700

    Added switch item

    Enact-DCO-1.0-Signed-off-by: Derek Tor <derek.tor@lge.com>

commit 716f217
Author: Ryan Duffy <ryan@tiqtech.com>
Date:   Thu Sep 6 09:18:07 2018 -0700

    Add navigation support using pushState (#9)

    * add navigation support using pushState

    Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>

    * fix merge

    Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>

commit 9006516
Merge: 9af9493 0b3cb07
Author: Ryan Duffy <ryan@tiqtech.com>
Date:   Thu Sep 6 08:59:55 2018 -0700

    Merge pull request #8 from enactjs/feature/hvac

    Add initial HVAC view

commit 0b3cb07
Author: Ryan Duffy <ryan.duffy@lge.com>
Date:   Wed Sep 5 18:10:04 2018 -0700

    add icon

    Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>

commit 0e43447
Merge: c7eeaba 43d3f67
Author: Ryan Duffy <ryan.duffy@lge.com>
Date:   Wed Sep 5 18:05:34 2018 -0700

    Merge branch 'feature/hvac' of github.com:enactjs/agate-apps into feature/hvac

commit c7eeaba
Author: Ryan Duffy <ryan.duffy@lge.com>
Date:   Wed Sep 5 18:05:16 2018 -0700

    cleanup styling

commit 43d3f67
Merge: 21c6391 9af9493
Author: Ryan Duffy <ryan@tiqtech.com>
Date:   Wed Sep 5 17:17:41 2018 -0700

    Merge branch 'master' into feature/hvac

commit 9af9493
Author: Roy Sutton <roy.sutton@lge.com>
Date:   Wed Sep 5 19:56:11 2018 -0400

    Close #14 - prevent pinch zoom

    Enact-DCO-1.0-Signed-off-by: Roy Sutton roy.sutton@lge.com

commit 21c6391
Author: Ryan Duffy <ryan.duffy@lge.com>
Date:   Fri Aug 31 13:23:33 2018 -0700

    clean up

    Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>

commit 1a1b35e
Author: Ryan Duffy <ryan.duffy@lge.com>
Date:   Fri Aug 31 13:15:27 2018 -0700

    add initial HVAC view

    Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
@ryanjduffy ryanjduffy mentioned this pull request Sep 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants