-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add initial HVAC view #8
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
teckliew
approved these changes
Sep 6, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lgtm:
Could add in |
sugardave
pushed a commit
that referenced
this pull request
Sep 6, 2018
commit b7d6b90 Author: Derek Tor <derek.tor@lge.com> Date: Thu Sep 6 11:36:57 2018 -0700 Added switch item Enact-DCO-1.0-Signed-off-by: Derek Tor <derek.tor@lge.com> commit 716f217 Author: Ryan Duffy <ryan@tiqtech.com> Date: Thu Sep 6 09:18:07 2018 -0700 Add navigation support using pushState (#9) * add navigation support using pushState Signed-off-by: Ryan Duffy <ryan.duffy@lge.com> * fix merge Signed-off-by: Ryan Duffy <ryan.duffy@lge.com> commit 9006516 Merge: 9af9493 0b3cb07 Author: Ryan Duffy <ryan@tiqtech.com> Date: Thu Sep 6 08:59:55 2018 -0700 Merge pull request #8 from enactjs/feature/hvac Add initial HVAC view commit 0b3cb07 Author: Ryan Duffy <ryan.duffy@lge.com> Date: Wed Sep 5 18:10:04 2018 -0700 add icon Signed-off-by: Ryan Duffy <ryan.duffy@lge.com> commit 0e43447 Merge: c7eeaba 43d3f67 Author: Ryan Duffy <ryan.duffy@lge.com> Date: Wed Sep 5 18:05:34 2018 -0700 Merge branch 'feature/hvac' of github.com:enactjs/agate-apps into feature/hvac commit c7eeaba Author: Ryan Duffy <ryan.duffy@lge.com> Date: Wed Sep 5 18:05:16 2018 -0700 cleanup styling commit 43d3f67 Merge: 21c6391 9af9493 Author: Ryan Duffy <ryan@tiqtech.com> Date: Wed Sep 5 17:17:41 2018 -0700 Merge branch 'master' into feature/hvac commit 9af9493 Author: Roy Sutton <roy.sutton@lge.com> Date: Wed Sep 5 19:56:11 2018 -0400 Close #14 - prevent pinch zoom Enact-DCO-1.0-Signed-off-by: Roy Sutton roy.sutton@lge.com commit 21c6391 Author: Ryan Duffy <ryan.duffy@lge.com> Date: Fri Aug 31 13:23:33 2018 -0700 clean up Signed-off-by: Ryan Duffy <ryan.duffy@lge.com> commit 1a1b35e Author: Ryan Duffy <ryan.duffy@lge.com> Date: Fri Aug 31 13:15:27 2018 -0700 add initial HVAC view Signed-off-by: Ryan Duffy <ryan.duffy@lge.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue: #6
SliderButton
rather than adding a slider but we can harvest that as well if desiredNeeds:
Button
instead ofLabeledIconButton
once the icons are meaningful