Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRO-7988: Fixed Scroller: PagingControls does not work #660

Merged
merged 4 commits into from
Jul 8, 2022

Conversation

stanca-pop-lgp
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp commented Jul 8, 2022

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

In sampler, when opening Scroller, Paging Controls was disabled. Scrolling started only after a wheel event was activated. Because of a recent change in Enact ui, scrollbar was being handled synchronously, so the ScrollButtons were not updated on first render.

Resolution

We changed useEffect to useLayoutEffect in Scrollbar.js to get the updated state of the buttons.

Additional Considerations

Links

WRO-7988

Comments

@daniel-stoian-lgp
Copy link
Contributor

daniel-stoian-lgp commented Jul 8, 2022

I think we need a changelog to describe the fix, although the location of the fix is in private component . Check enactjs/enact#3066

Fixed

  • agate/Scroller and agate/Virtuallist to have scrollButtons active on initial render

you can choose a better description, mine is just for demo

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adrian-cocoara-lgp adrian-cocoara-lgp merged commit d4ac320 into develop Jul 8, 2022
@adrian-cocoara-lgp adrian-cocoara-lgp deleted the feature/WRO-7988 branch July 8, 2022 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants