WRP-4092: IncrementSlider - refactor utils.js #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 74.55% // Head: 74.74% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #707 +/- ##
===========================================
+ Coverage 74.55% 74.74% +0.18%
===========================================
Files 120 120
Lines 4500 4510 +10
Branches 1253 1262 +9
===========================================
+ Hits 3355 3371 +16
+ Misses 877 874 -3
+ Partials 268 265 -3
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
daniel-stoian-lgp
approved these changes
Dec 7, 2022
|
note for the next reviewer: since the deleted functions are private, we think a changelog is not necesary. Please correct us if we are wrong |
# Conflicts: # IncrementSlider/IncrementSlider.js
juwonjeong
reviewed
Dec 16, 2022
|
I agree with @daniel-stoian-lgp that this fix does not need to add CHANGELOG. |
# Conflicts: # IncrementSlider/IncrementSlider.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com
Checklist
Issue Resolved / Feature Added
IncrementSlider/utils.jscontains some copied functions formSlider/utis.jswhich are not used in the implementation of component, so they were removed.Resolution
Additional Considerations
Links
WRP-4092
Comments