-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRP-6109: Added extra publicClassNames for ImageItem and Popup #715
Conversation
Codecov ReportBase: 80.67% // Head: 80.67% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #715 +/- ##
========================================
Coverage 80.67% 80.67%
========================================
Files 120 120
Lines 4446 4446
Branches 1222 1222
========================================
Hits 3587 3587
Misses 669 669
Partials 190 190
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but lets see SWP opinion
…nto feature/WRP-6109
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@seunghoh , can you review this PR? your comment was solved. Merging is blocked at the moment |
Checklist
Issue Resolved / Feature Added
While working on agate-apps repo, it was discovered that ImageItem didn't have any publicClassNames available for customization and Popup didn't have the
content
className publicResolution
Added extra publicClassNames for ImageItem and Popup
Additional Considerations
Links
WRP-6109
Comments
Enact-DCO-1.0-Signed-off-by: Daniel Stoian daniel.stoian@lgepartner.com