Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-6109: Added extra publicClassNames for ImageItem and Popup #715

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

daniel-stoian-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

While working on agate-apps repo, it was discovered that ImageItem didn't have any publicClassNames available for customization and Popup didn't have the content className public

Resolution

Added extra publicClassNames for ImageItem and Popup

Additional Considerations

Links

WRP-6109

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian daniel.stoian@lgepartner.com

@codecov
Copy link

codecov bot commented Jan 5, 2023

Codecov Report

Base: 80.67% // Head: 80.67% // No change to project coverage 👍

Coverage data is based on head (5728fc6) compared to base (da8dc15).
Patch has no changes to coverable lines.

❗ Current head 5728fc6 differs from pull request most recent head 3340101. Consider uploading reports for the commit 3340101 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #715   +/-   ##
========================================
  Coverage    80.67%   80.67%           
========================================
  Files          120      120           
  Lines         4446     4446           
  Branches      1222     1222           
========================================
  Hits          3587     3587           
  Misses         669      669           
  Partials       190      190           
Impacted Files Coverage Δ
ImageItem/ImageItem.js 100.00% <ø> (ø)
Popup/Popup.js 96.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but lets see SWP opinion

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@daniel-stoian-lgp
Copy link
Contributor Author

daniel-stoian-lgp commented Jan 15, 2023

@seunghoh , can you review this PR? your comment was solved. Merging is blocked at the moment

@stanca-pop-lgp stanca-pop-lgp merged commit f17e2ea into develop Jan 17, 2023
@stanca-pop-lgp stanca-pop-lgp deleted the feature/WRP-6109 branch January 17, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants