Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-6584: Fixed failed ui tests on Jenkins #716

Merged
merged 15 commits into from
Jan 20, 2023
Merged

Conversation

stanca-pop-lgp
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp commented Jan 13, 2023

Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Ui tests job on Jenkins for Agate develop branch are failing for Drawer (with scrimType - none should have correct heading) and SwitchItem (pointer should re-select the item when clicked twice).

Resolution

For Drawer I changed waitForOpen and waitForClose to be asyncronous. They both use waitForExist command from webdriverio which must be used inside async functions (https://webdriver.io/docs/api/element/waitForExist/).
For SwitchItem I refocused the element before selecting it again.

Additional Considerations

When running the changes a new test failed for TimePicker so I added a browser pause to wait for the animation to be completed.

Links

WRP-6584

Comments

@codecov
Copy link

codecov bot commented Jan 13, 2023

Codecov Report

Base: 80.67% // Head: 82.22% // Increases project coverage by +1.54% 🎉

Coverage data is based on head (5e5154d) compared to base (da8dc15).
Patch has no changes to coverable lines.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #716      +/-   ##
===========================================
+ Coverage    80.67%   82.22%   +1.54%     
===========================================
  Files          120      120              
  Lines         4446     4451       +5     
  Branches      1222     1223       +1     
===========================================
+ Hits          3587     3660      +73     
+ Misses         669      628      -41     
+ Partials       190      163      -27     
Impacted Files Coverage Δ
ImageItem/ImageItem.js 100.00% <0.00%> (ø)
useScroll/useEvent.js 49.25% <0.00%> (+1.11%) ⬆️
Scroller/useThemeScroller.js 27.61% <0.00%> (+3.80%) ⬆️
useScroll/ScrollButton.js 100.00% <0.00%> (+20.00%) ⬆️
Scroller/useEvent.js 66.66% <0.00%> (+33.33%) ⬆️
useScroll/ScrollButtons.js 82.75% <0.00%> (+47.41%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@adrian-cocoara-lgp
Copy link
Contributor

adrian-cocoara-lgp commented Jan 16, 2023

The solution for adding async await for waitForExist function comes from version 8 of wdio documentation.
We are using v7 in ui-test-utils, and the docs for v7 does not include async await:
https://v7.webdriver.io/docs/api/element/waitForExist

We need to find another solution
Since we already have async await to other components (Panel, Popup, PopupMenu), I think this solution works.

@dongsuwon
Copy link
Contributor

LGTM

@dongsuwon dongsuwon merged commit 83aebe6 into develop Jan 20, 2023
@dongsuwon dongsuwon deleted the feature/WRP-6584 branch January 20, 2023 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants