-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRP-6584: Fixed failed ui tests on Jenkins #716
Conversation
Codecov ReportBase: 80.67% // Head: 82.22% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #716 +/- ##
===========================================
+ Coverage 80.67% 82.22% +1.54%
===========================================
Files 120 120
Lines 4446 4451 +5
Branches 1222 1223 +1
===========================================
+ Hits 3587 3660 +73
+ Misses 669 628 -41
+ Partials 190 163 -27
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
The solution for adding
|
LGTM |
Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com
Checklist
Issue Resolved / Feature Added
Ui tests job on Jenkins for Agate develop branch are failing for Drawer (with scrimType - none should have correct heading) and SwitchItem (pointer should re-select the item when clicked twice).
Resolution
For Drawer I changed
waitForOpen
andwaitForClose
to be asyncronous. They both usewaitForExist
command from webdriverio which must be used inside async functions (https://webdriver.io/docs/api/element/waitForExist/).For SwitchItem I refocused the element before selecting it again.
Additional Considerations
When running the changes a new test failed for TimePicker so I added a browser pause to wait for the animation to be completed.
Links
WRP-6584
Comments