Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-7672: Fixed border color for selected SwitchItem for Gallium skin #718

Merged
merged 6 commits into from
Feb 6, 2023

Conversation

ion-andrusciac-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When a SwitchItem with selected=true, there was no border color for Gallium skin on focus

Resolution

Fixed border color for selected SwitchItem for Gallium skin by modifying component less styling

Additional Considerations

Links

WRP-7672

Comments

Enact-DCO-1.0-Signed-off-by: Ion Andrusciac (ion.andrusciac@lgepartner.com)

@CLAassistant
Copy link

CLAassistant commented Jan 25, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 82.20% // Head: 82.20% // No change to project coverage 👍

Coverage data is based on head (66b0db1) compared to base (83aebe6).
Patch has no changes to coverable lines.

❗ Current head 66b0db1 differs from pull request most recent head 3d51d2b. Consider uploading reports for the commit 3d51d2b to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #718   +/-   ##
========================================
  Coverage    82.20%   82.20%           
========================================
  Files          120      120           
  Lines         4446     4446           
  Branches      1222     1222           
========================================
  Hits          3655     3655           
  Misses         628      628           
  Partials       163      163           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniel-stoian-lgp
Copy link
Contributor

since the screenshot tests did not catch the color change of the label described above, I think extra screenshot tests for focused state must be added for SwitchItem
Please check tests/screenshot/apps/components/SwitchItem.js and add a new section

	// Focus
	...withConfig({focus: true}, [
	  <SwitchItem />,
	  <SwitchItem>Hello SwitchItem</SwitchItem>,
	  <SwitchItem selected>Hello SwitchItem</SwitchItem>,
	  <SwitchItem disabled>Hello SwitchItem</SwitchItem>,
	  <SwitchItem icon="music">Hello SwitchItem</SwitchItem>
	]),

Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! congrats for ur 1st PR 🥳

@seunghoh
Copy link
Member

@ion-andrusciac-lgp Welcome aboard! I'd like to mention your commit message.
"Minor fix" Doesn't have any information. You should describe more specifically.

@0x64 0x64 merged commit e802f5e into develop Feb 6, 2023
@0x64 0x64 deleted the feature/WRP-7672 branch February 6, 2023 02:45
stanca-pop-lgp pushed a commit that referenced this pull request Feb 9, 2023
…#718)

* Fixed border color for selected SwitchItem

* Added Changelog

* Minor fix

* Minor fix and added ss-tests for SwitchItem

* minor fix

---------

Co-authored-by: Daniel Stoian <daniel.stoian@lgepartner.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants