-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRP-7672: Fixed border color for selected SwitchItem for Gallium skin #718
Conversation
Codecov ReportBase: 82.20% // Head: 82.20% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## develop #718 +/- ##
========================================
Coverage 82.20% 82.20%
========================================
Files 120 120
Lines 4446 4446
Branches 1222 1222
========================================
Hits 3655 3655
Misses 628 628
Partials 163 163 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
since the screenshot tests did not catch the color change of the label described above, I think extra screenshot tests for focused state must be added for SwitchItem
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! congrats for ur 1st PR 🥳
@ion-andrusciac-lgp Welcome aboard! I'd like to mention your commit message. |
…#718) * Fixed border color for selected SwitchItem * Added Changelog * Minor fix * Minor fix and added ss-tests for SwitchItem * minor fix --------- Co-authored-by: Daniel Stoian <daniel.stoian@lgepartner.com>
Checklist
Issue Resolved / Feature Added
When a SwitchItem with selected=true, there was no border color for Gallium skin on focus
Resolution
Fixed border color for selected SwitchItem for Gallium skin by modifying component less styling
Additional Considerations
Links
WRP-7672
Comments
Enact-DCO-1.0-Signed-off-by: Ion Andrusciac (ion.andrusciac@lgepartner.com)