Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-3075: Updated dependencies for agate, agate samplers and agate storybook #719

Merged
merged 8 commits into from
Feb 22, 2023

Conversation

alexandrumorariu
Copy link
Contributor

@alexandrumorariu alexandrumorariu commented Jan 31, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Updated package.json dependencies to fix security vulnerabilities.

Resolution

Updated package.json dependencies to fix security vulnerabilities.

Additional Considerations

Links

WRP-3075

Comments

Enact-DCO-1.0-Signed-off-by: Alexandru Morariu alexandru.morariu@lgepartner.com

@codecov
Copy link

codecov bot commented Jan 31, 2023

Codecov Report

Base: 82.21% // Head: 82.21% // No change to project coverage 👍

Coverage data is based on head (fe7ef38) compared to base (1264311).
Patch has no changes to coverable lines.

❗ Current head fe7ef38 differs from pull request most recent head 0860b38. Consider uploading reports for the commit 0860b38 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #719   +/-   ##
========================================
  Coverage    82.21%   82.21%           
========================================
  Files          120      120           
  Lines         4447     4447           
  Branches      1223     1223           
========================================
  Hits          3656     3656           
  Misses         628      628           
  Partials       163      163           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hong6316
Copy link
Contributor

hong6316 commented Feb 22, 2023

Before updating the version of ilib, you must also update the version of ilib-webos.
(

"ilib": "^14.15.1 || ^14.15.1-webos1"
)

If ilib-webos does not have the same version, please do not update and keep the version of ilib.

Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit cca9eaa into develop Feb 22, 2023
@hong6316 hong6316 deleted the feature/WRP-3075 branch February 22, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants