WRP-3197: Create DropManager qa-sample and unit tests #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportBase: 82.21% // Head: 83.87% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #721 +/- ##
===========================================
+ Coverage 82.21% 83.87% +1.66%
===========================================
Files 120 120
Lines 4447 4447
Branches 1223 1223
===========================================
+ Hits 3656 3730 +74
+ Misses 628 564 -64
+ Partials 163 153 -10
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
daniel-stoian-lgp
changed the title
daniel-stoian-lgp
approved these changes
Feb 7, 2023
stanca-pop-lgp
force-pushed
the
feature/WRP-3197
branch
3 times, most recently
from
6939407
to
98d4cc6
Compare
daniel-stoian-lgp
approved these changes
Feb 9, 2023
0x64
reviewed
Feb 20, 2023
0x64
requested changes
Feb 21, 2023
samples/qa-drag-and-drop/src/components/CustomLayout/CustomLayout.js
Outdated
Show resolved
Hide resolved
Co-authored-by: Seungcheon Baek <5037955+0x64@users.noreply.github.com>
0x64
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Stanca Pop stanca.pop@lgepartner.com
Checklist
Issue Resolved / Feature Added
Investigate DropManger for list drag & drop feature.
Resolution
Added qa-sampler and unit tests.
Additional Considerations
Drag and drop uses HTML Drag and Drop API and could not be tested with React Testing Library.
Links
WRP-3197
Comments