Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-9586: Fixed "not wrapped in act()" console error for unit tests #736

Merged
merged 1 commit into from
Mar 15, 2023

Conversation

andreitirlalge
Copy link
Contributor

@andreitirlalge andreitirlalge commented Mar 14, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

When running unit tests for Agate/Input, some console errors are shown although the tests passed.

Resolution

By reordering the problematic tests, we were able to prevent the console errors from being triggered.

Additional Considerations

We couldn't find the root cause of the problem at this moment, we tried implementing some solutions found online but they did not work and weren't applicable.

Links

WRP-9586

Comments

Enact-DCO-1.0-Signed-off-by: Andrei Tirla andrei.tirla@lgepartner.com

@codecov
Copy link

codecov bot commented Mar 14, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (d0301c9) 83.87% compared to head (769efce) 83.87%.

❗ Current head 769efce differs from pull request most recent head 60783c1. Consider uploading reports for the commit 60783c1 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #736   +/-   ##
========================================
  Coverage    83.87%   83.87%           
========================================
  Files          120      120           
  Lines         4447     4447           
  Branches      1223     1223           
========================================
  Hits          3730     3730           
  Misses         564      564           
  Partials       153      153           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@daniel-stoian-lgp daniel-stoian-lgp merged commit 5277c8d into develop Mar 15, 2023
@daniel-stoian-lgp daniel-stoian-lgp deleted the feature/WRP-9586 branch March 15, 2023 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants