WRP-12450: Adapted DropManager for touchscreen devices #740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop #740 +/- ##
===========================================
+ Coverage 85.11% 85.20% +0.09%
===========================================
Files 120 120
Lines 4447 4495 +48
Branches 1223 1235 +12
===========================================
+ Hits 3785 3830 +45
- Misses 517 520 +3
Partials 145 145
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
daniel-stoian-lgp
changed the title
|
|
||
| fireEvent.touchStart(topSlot, {touches: [current]}); | ||
|
|
||
| document.elementFromPoint = jest.fn(() => { |
There was a problem hiding this comment.
function had to be manually declared because jsdom does not support it by default
adrian-cocoara-lgp
approved these changes
Apr 13, 2023
0x64
approved these changes
Apr 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enact-DCO-1.0-Signed-off-by: Daniel Stoian daniel.stoian@lgepartner.com
Checklist
Issue Resolved / Feature Added
DropManager did not work on touchscreen devices
Resolution
Added handling for touchStart, touchMove and touchEnd events
Additional Considerations
There is no drag image on touch events, but the drop area is easily visible, thanks to the already available classnames that are assigned to the drop areas.
Links
WRP-12450
Comments