Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-15107: Update unit tests to work with @testing-library/user-event 14 #743

Merged
merged 2 commits into from
May 12, 2023

Conversation

andreitirlalge
Copy link
Contributor

@andreitirlalge andreitirlalge commented May 10, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

@testing-library/user-event version 14 introduced API changes so we need to update unit tests.

Resolution

Updated tests that are using @testing-library/user-event module.

Additional Considerations

This PR should be merged after @enact/cli 6.0.0 is released, otherwise, Travis will be broken.

Links

WRP-15107

Comments

Enact-DCO-1.0-Signed-off-by: Andrei Tirla andrei.tirla@lgepartner.com

@codecov
Copy link

codecov bot commented May 10, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.14 ⚠️

Comparison is base (d3aac7c) 85.20% compared to head (4204050) 85.07%.

❗ Current head 4204050 differs from pull request most recent head bc553b5. Consider uploading reports for the commit bc553b5 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #743      +/-   ##
===========================================
- Coverage    85.20%   85.07%   -0.14%     
===========================================
  Files          120      120              
  Lines         4495     4495              
  Branches      1235     1235              
===========================================
- Hits          3830     3824       -6     
- Misses         520      524       +4     
- Partials       145      147       +2     

see 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Contributor

@MikyungKim MikyungKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@0x64
Copy link
Member

0x64 commented May 12, 2023

Checked coverage drop from PopupState, and looks okay.

@0x64 0x64 merged commit 11fac22 into develop May 12, 2023
@0x64 0x64 deleted the feature/WRP-15107 branch May 12, 2023 04:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants