WRP-20616: Added additional support for custom skin

[daniel-stoian-lgp]

Checklist

• I have read and understand the contribution guide
• A CHANGELOG entry is included
• At least one test case is included for this feature or bug fix
• Documentation was added or is not needed
• Documentation was verified or is not changed
• UI test was passed or is not needed
• Screenshot test was verified or is not needed
• This is an API breaking change

Issue Resolved / Feature Added

Added additional support for custom skin:

• removed orphan variable @agate-slider-color.

• added:
  --agate-bg-color
  --agate-component-bg-color
  --agate-component-text-color
  --agate-focus-bg-color
  --agate-focus-color
  --agate-text-color
  --agate-text-sub-color
  --agate-title-text-color
  --agate-toggle-off-color
  --agate-toggle-on-color
  --agate-toggle-off-bg-color
  --agate-toggle-on-bg-color
  --agate-item-bg-color

• unfortunately, the patterns are not linear in every skin: for example, i wanted to apply --agate-toggle-XX variabled to toggleButton colors, but they are not the same as the Switch colors

Resolution

Additional Considerations

Some screenshot tests fail on Silicon skin because i changed the background-color for the focused button from transparent to agate-accent, but on a normal screen the difference is not visible because the background-color is covered by the background-image:

Links

WRP-20616

Comments

Enact-DCO-1.0-Signed-off-by: Daniel Stoian daniel.stoian@lgepartner.com

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (94abdfe) 85.07% compared to head (231a0b1) 85.07%.

❗ Current head 231a0b1 differs from pull request most recent head 810902a. Consider uploading reports for the commit 810902a to get more accurate results

Additional details and impacted files

@@                 Coverage Diff                 @@
##           feature/customSkin     #754   +/-   ##
===================================================
  Coverage               85.07%   85.07%           
===================================================
  Files                     120      120           
  Lines                    4495     4495           
  Branches                 1235     1235           
===================================================
  Hits                     3824     3824           
  Misses                    524      524           
  Partials                  147      147           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.