Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-26842: Fixed ui-test fail for VirtualGridList #758

Merged
merged 1 commit into from
Sep 12, 2023

Conversation

andreitirlalge
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • Documentation was verified or is not changed
  • UI test was passed or is not needed
  • Screenshot test was verified or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Ui-test nightly job on Jenkins for Agate develop branch is failing for VirtualGridList(should focus "item0" but instead it focuses on "item12").

Resolution

I added a browser.pause before Page.SpotlightSelect() in order to wait for the Page.spotlightDown() to reach the correct item, in our case, 'item0'.

Additional Considerations

Links

WRP-26942

Comments

Enact-DCO-1.0-Signed-off-by: Andrei Tirla andrei.tirla@lgepartner.com

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (24116cd) 85.09% compared to head (5ffc3f2) 85.09%.

❗ Current head 5ffc3f2 differs from pull request most recent head eef3517. Consider uploading reports for the commit eef3517 to get more accurate results

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #758   +/-   ##
========================================
  Coverage    85.09%   85.09%           
========================================
  Files          120      120           
  Lines         4495     4495           
  Branches      1235     1235           
========================================
  Hits          3825     3825           
  Misses         523      523           
  Partials       147      147           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

@dongsuwon
Copy link
Contributor

LGTM

@dongsuwon dongsuwon merged commit fb11893 into develop Sep 12, 2023
4 checks passed
@dongsuwon dongsuwon deleted the feature/WRP-26842 branch September 12, 2023 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants