WRQ-19325: Updated Panels' Header to work with changed DOM structure of Spottable #792
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
5 tasks
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #792 +/- ##
========================================
Coverage 85.13% 85.13%
========================================
Files 120 120
Lines 4507 4507
Branches 1237 1237
========================================
Hits 3837 3837
Misses 523 523
Partials 147 147 ☔ View full report in Codecov by Sentry. |
… with the corresponding Enact changes Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
As DOM structure of ui/Spottable is updated in enactjs/enact/pull/3243, the corresponding internal style sheet needs to be updated.
Resolution
Updated the related styles.
Also, unit tests for ColorPicker, MediaPlayer, and TabGroup are updated due to DOM structure changes.
Additional Considerations
Links
WRQ-19325
enactjs/enact/pull/3243
Comments
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)