Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-25856: Add missing ui/ss tests for Arc --> MediaPlayer #796

Merged
merged 6 commits into from
Jul 26, 2024

Conversation

paul-beldean-lgp
Copy link
Contributor

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added missing ui/ss tests

Resolution

Added missing ui/ss tests

Additional Considerations

I needed to change Agate-View so that I could add padding to the wrapper (like on Sandstone).

Links

WRQ-25856

Comments

Enact-DCO-1.0-Signed-off-by: Paul Beldean paul.beldean@lgepartner.com

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (a4f380f) to head (66579cc).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #796   +/-   ##
========================================
  Coverage    84.88%   84.88%           
========================================
  Files          120      120           
  Lines         4506     4506           
  Branches      1236     1236           
========================================
  Hits          3825     3825           
  Misses         527      527           
  Partials       154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-cocoara-lgp adrian-cocoara-lgp changed the title WRQ-25856: Added missing ui/ss tests WRQ-25856: Add missing ui/ss tests for Arc --> MediaPlayer Jul 5, 2024
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongsuwon
Copy link
Contributor

LGTM

@dongsuwon dongsuwon merged commit 47e9790 into develop Jul 26, 2024
7 checks passed
@dongsuwon dongsuwon deleted the feature/WRQ-25856 branch July 26, 2024 01:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants