Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-25858: Add missing ui/ss tests for Panel --> WindDirectionControl #797

Merged
merged 18 commits into from
Aug 22, 2024

Conversation

adrian-cocoara-lgp
Copy link
Contributor

@adrian-cocoara-lgp adrian-cocoara-lgp commented Jul 5, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Added missing ui and screenshot tests for Panel -> WindDirectionControl components

Resolution

Added new ui-tests for TabbedPanels
Added missing ui-tests for: Picker, RangePicker
Added new ss-tests for TabbedPanels and VirtualGridList
Added missing ss-tests for: Popup, PopupMenu, Slider, SliderButton, SwitchItem, TimePicker, ToggleButton, TooltipDecorator, WindDirectionControl

Additional Considerations

Links

WRQ-25858

Comments

Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com

Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (bbc809f) to head (ff85940).
Report is 1 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #797   +/-   ##
========================================
  Coverage    84.88%   84.88%           
========================================
  Files          120      120           
  Lines         4506     4506           
  Branches      1237     1237           
========================================
  Hits          3825     3825           
  Misses         527      527           
  Partials       154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adrian-cocoara-lgp adrian-cocoara-lgp changed the title WRQ-25858: Find missing ui/ss tests scenarios and create them for Panel --> WindDirectionControl WRQ-25858: Add missing ui/ss tests for Panel --> WindDirectionControl Jul 5, 2024
tests/screenshot/apps/components/VirtualGridList.js Outdated Show resolved Hide resolved
tests/ui/apps/RangePicker/RangePicker-View.js Outdated Show resolved Hide resolved
tests/ui/apps/TabbedPanels/TabbedPanels-View.js Outdated Show resolved Hide resolved
tests/ui/specs/RangePicker/RangePicker-specs.js Outdated Show resolved Hide resolved
tests/ui/specs/RangePicker/RangePickerPage.js Outdated Show resolved Hide resolved
tests/ui/specs/Picker/PickerPage.js Outdated Show resolved Hide resolved
Copy link
Contributor

@stanca-pop-lgp stanca-pop-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tests/screenshot/apps/components/Popup.js Outdated Show resolved Hide resolved
tests/screenshot/apps/components/Popup.js Outdated Show resolved Hide resolved
tests/screenshot/apps/components/Popup.js Outdated Show resolved Hide resolved
tests/screenshot/apps/components/TimePicker.js Outdated Show resolved Hide resolved
@dongsuwon
Copy link
Contributor

LGTM

@dongsuwon dongsuwon merged commit 1828ede into develop Aug 22, 2024
7 checks passed
@dongsuwon dongsuwon deleted the feature/WRQ-25858 branch August 22, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants