-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-25858: Add missing ui/ss tests for Panel --> WindDirectionControl #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #797 +/- ##
========================================
Coverage 84.88% 84.88%
========================================
Files 120 120
Lines 4506 4506
Branches 1237 1237
========================================
Hits 3825 3825
Misses 527 527
Partials 154 154 ☔ View full report in Codecov by Sentry. |
adrian-cocoara-lgp
changed the title
WRQ-25858: Find missing ui/ss tests scenarios and create them for Panel --> WindDirectionControl
WRQ-25858: Add missing ui/ss tests for Panel --> WindDirectionControl
Jul 5, 2024
stanca-pop-lgp
requested changes
Jul 10, 2024
stanca-pop-lgp
approved these changes
Jul 11, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
dongsuwon
reviewed
Jul 19, 2024
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Added missing ui and screenshot tests for Panel -> WindDirectionControl components
Resolution
Added new ui-tests for
TabbedPanels
Added missing ui-tests for:
Picker
,RangePicker
Added new ss-tests for
TabbedPanels
andVirtualGridList
Added missing ss-tests for:
Popup
,PopupMenu
,Slider
,SliderButton
,SwitchItem
,TimePicker
,ToggleButton
,TooltipDecorator
,WindDirectionControl
Additional Considerations
Links
WRQ-25858
Comments
Enact-DCO-1.0-Signed-off-by: Adrian Cocoara adrian.cocoara@lgepartner.com