-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRQ-29884: Change cli branch in travis.yml to master #800
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #800 +/- ##
========================================
Coverage 84.89% 84.89%
========================================
Files 120 120
Lines 4508 4508
Branches 1237 1238 +1
========================================
Hits 3827 3827
Misses 527 527
Partials 154 154 ☔ View full report in Codecov by Sentry. |
hong6316
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
0x64
pushed a commit
that referenced
this pull request
Jul 22, 2024
* WRQ-29884: Change cli branch in travis.yml to master (#800) Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * fixed virtualgridlist story to load default values * minor fix --------- Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>
0x64
pushed a commit
that referenced
this pull request
Jul 25, 2024
…#803) * WRQ-7108: Remove unnecessary vendor prefixes (#784) * WRQ-7108: Remove unnecessary vendor prefixes Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * remove more vendor prefix * remove more vendor prefix Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * WRQ-25866: Update package dependencies to fix security vulnerabilities. (#795) * Updated dependencies for agate library. * Updated shrinkwrap * WRP-26873: Fixed partial Panels' transition on horizontal (#757) * Fixed partial transition * Fixed lint warnings * Added code was covered by tests * Added CHANGELOG * Review fixes * Restored style changes * Update CHANGELOG.md * Fixed changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Review fixes * Review fixes * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update dependencies and sampler version to 2.0.11 * WRQ-29884: Change cli branch in travis.yml to master (#800) Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * WRQ-29957: Fixed VirtualGridList story to load default values (#801) * WRQ-29884: Change cli branch in travis.yml to master (#800) Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * fixed virtualgridlist story to load default values * minor fix --------- Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com> * Update a change log for 2.0.11 * Version value updating * fix travis.yml Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * remove empty options Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * update enact dependencies in package.json Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * Updated sampler's npm shrinkwrap --------- Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: Jenkins <accounts@enactjs.com>
0x64
pushed a commit
that referenced
this pull request
Jul 25, 2024
* WRQ-22937: Updated storybook to version 8 (#791) * updated storybook to version 8.1.5 * Fixed custom toolbars for acent, hightlight and default skin styles * code review fixes * removed parasite div * code review fixes * eslint fixes * removed unneeded storybook ui props * updated storybook to 8.1.6 and storybook-tils branch to enact_v5 * removed docs configuration and docs information in About story * WRQ-25915: Added custom site icon for sampler app (#793) * added custom site icon for storybook * Apply suggestions from code review * removed manager-head.html --------- Co-authored-by: Stanca <stanca.pop@lgepartner.com> * WRQ-17541: Fix Marquee to not override marqueeDirection (#794) * Fix Marquee to not override marqueeDirection * modify travis.yml to verify * remove null * modify travis.yml to verify 2 * WRQ-29126: Updated storybook to 8.2 (#799) * Updated storybook to 8.2 and applied latest patch version * updatet storybook dependencies to use latest minor version * changed package order --------- Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRQ-30274: Prepare for merging `feature/enact_v5` to `develop` branch (#803) * WRQ-7108: Remove unnecessary vendor prefixes (#784) * WRQ-7108: Remove unnecessary vendor prefixes Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * remove more vendor prefix * remove more vendor prefix Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * WRQ-25866: Update package dependencies to fix security vulnerabilities. (#795) * Updated dependencies for agate library. * Updated shrinkwrap * WRP-26873: Fixed partial Panels' transition on horizontal (#757) * Fixed partial transition * Fixed lint warnings * Added code was covered by tests * Added CHANGELOG * Review fixes * Restored style changes * Update CHANGELOG.md * Fixed changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Review fixes * Review fixes * fix Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update dependencies and sampler version to 2.0.11 * WRQ-29884: Change cli branch in travis.yml to master (#800) Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * WRQ-29957: Fixed VirtualGridList story to load default values (#801) * WRQ-29884: Change cli branch in travis.yml to master (#800) Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * fixed virtualgridlist story to load default values * minor fix --------- Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com> * Update a change log for 2.0.11 * Version value updating * fix travis.yml Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * change travis dist from focal to jammy Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * remove empty options Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * update enact dependencies in package.json Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com) * Updated sampler's npm shrinkwrap --------- Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com> Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: Jenkins <accounts@enactjs.com> --------- Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com> Co-authored-by: Stanca <stanca.pop@lgepartner.com> Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com> Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com> Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com> Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com> Co-authored-by: Jenkins <accounts@enactjs.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
travis error occurs due to a lot of console warnings.
https://github.com/enactjs/agate/runs/27537930727
Resolution
we checked this error does not occur with cli master branch,
so we change cli branch in travis.yml file to master temporarily.
Additional Considerations
after fixing the problem, we should revert the branch.
Links
WRQ-29884
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)