Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-29884: Change cli branch in travis.yml to master #800

Merged
merged 1 commit into from
Jul 19, 2024

Conversation

vJIYEv
Copy link
Contributor

@vJIYEv vJIYEv commented Jul 18, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

travis error occurs due to a lot of console warnings.
https://github.com/enactjs/agate/runs/27537930727

Resolution

we checked this error does not occur with cli master branch,
so we change cli branch in travis.yml file to master temporarily.

Additional Considerations

after fixing the problem, we should revert the branch.

Links

WRQ-29884

Comments

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
Copy link

codecov bot commented Jul 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.89%. Comparing base (ca7f6b7) to head (ca9f205).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #800   +/-   ##
========================================
  Coverage    84.89%   84.89%           
========================================
  Files          120      120           
  Lines         4508     4508           
  Branches      1237     1238    +1     
========================================
  Hits          3827     3827           
  Misses         527      527           
  Partials       154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@hong6316 hong6316 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@hong6316 hong6316 merged commit 3c615cf into develop Jul 19, 2024
7 checks passed
@hong6316 hong6316 deleted the feature/WRQ-29884 branch July 19, 2024 04:27
0x64 pushed a commit that referenced this pull request Jul 22, 2024
* WRQ-29884: Change cli branch in travis.yml to master (#800)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* fixed virtualgridlist story to load default values

* minor fix

---------

Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>
0x64 pushed a commit that referenced this pull request Jul 25, 2024
…#803)

* WRQ-7108: Remove unnecessary vendor prefixes (#784)

* WRQ-7108: Remove unnecessary vendor prefixes
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* remove more vendor prefix

* remove more vendor prefix
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* WRQ-25866: Update package dependencies to fix security vulnerabilities. (#795)

* Updated dependencies for agate library.

* Updated shrinkwrap

* WRP-26873: Fixed partial Panels' transition on horizontal (#757)

* Fixed partial transition

* Fixed lint warnings

* Added code was covered by tests

* Added CHANGELOG

* Review fixes

* Restored style changes

* Update CHANGELOG.md

* Fixed changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Review fixes

* Review fixes

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

---------

Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update dependencies and sampler version to 2.0.11

* WRQ-29884: Change cli branch in travis.yml to master (#800)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* WRQ-29957: Fixed VirtualGridList story to load default values (#801)

* WRQ-29884: Change cli branch in travis.yml to master (#800)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* fixed virtualgridlist story to load default values

* minor fix

---------

Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>

* Update a change log for 2.0.11

* Version value updating

* fix travis.yml
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* change travis dist from focal to jammy
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* remove empty options
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* update enact dependencies in package.json
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* Updated sampler's npm shrinkwrap

---------

Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com>
Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com>
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com>
Co-authored-by: Jenkins <accounts@enactjs.com>
0x64 pushed a commit that referenced this pull request Jul 25, 2024
* WRQ-22937: Updated storybook to version 8 (#791)

* updated storybook to version 8.1.5

* Fixed custom toolbars for acent, hightlight and default skin styles

* code review fixes

* removed parasite div

* code review fixes

* eslint fixes

* removed unneeded storybook ui props

* updated storybook to 8.1.6 and storybook-tils branch to enact_v5

* removed docs configuration and docs information in About story

* WRQ-25915: Added custom site icon for sampler app (#793)

* added custom site icon for storybook

* Apply suggestions from code review

* removed manager-head.html

---------

Co-authored-by: Stanca <stanca.pop@lgepartner.com>

* WRQ-17541: Fix Marquee to not override marqueeDirection (#794)

* Fix Marquee to not override marqueeDirection

* modify travis.yml to verify

* remove null

* modify travis.yml to verify 2

* WRQ-29126: Updated storybook to 8.2 (#799)

* Updated storybook to 8.2 and applied latest patch version

* updatet storybook dependencies to use latest minor version

* changed package order

---------

Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* WRQ-30274: Prepare for merging `feature/enact_v5` to `develop` branch (#803)

* WRQ-7108: Remove unnecessary vendor prefixes (#784)

* WRQ-7108: Remove unnecessary vendor prefixes
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* remove more vendor prefix

* remove more vendor prefix
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* WRQ-25866: Update package dependencies to fix security vulnerabilities. (#795)

* Updated dependencies for agate library.

* Updated shrinkwrap

* WRP-26873: Fixed partial Panels' transition on horizontal (#757)

* Fixed partial transition

* Fixed lint warnings

* Added code was covered by tests

* Added CHANGELOG

* Review fixes

* Restored style changes

* Update CHANGELOG.md

* Fixed changelog

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

* Review fixes

* Review fixes

* fix

Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com)

---------

Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>

* Update dependencies and sampler version to 2.0.11

* WRQ-29884: Change cli branch in travis.yml to master (#800)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* WRQ-29957: Fixed VirtualGridList story to load default values (#801)

* WRQ-29884: Change cli branch in travis.yml to master (#800)

Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* fixed virtualgridlist story to load default values

* minor fix

---------

Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>

* Update a change log for 2.0.11

* Version value updating

* fix travis.yml
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* change travis dist from focal to jammy
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* remove empty options
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* update enact dependencies in package.json
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)

* Updated sampler's npm shrinkwrap

---------

Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com>
Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com>
Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com>
Co-authored-by: Jenkins <accounts@enactjs.com>

---------

Co-authored-by: Daniel Stoian <63335068+daniel-stoian-lgp@users.noreply.github.com>
Co-authored-by: Stanca <stanca.pop@lgepartner.com>
Co-authored-by: taeyoung.hong <taeyoung.hong@lge.com>
Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Co-authored-by: Jiye Kim <128779942+vJIYEv@users.noreply.github.com>
Co-authored-by: alexandru-morariu-lgp <84004128+alexandrumorariu@users.noreply.github.com>
Co-authored-by: ion-andrusciac-lgp <122601449+ion-andrusciac-lgp@users.noreply.github.com>
Co-authored-by: Jenkins <accounts@enactjs.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants