Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-29377: Fix ToggleButton underline position #806

Merged
merged 4 commits into from
Aug 9, 2024

Conversation

paul-beldean-lgp
Copy link
Contributor

@paul-beldean-lgp paul-beldean-lgp commented Jul 31, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Fix ToggleButton underline position

Resolution

Fix ToggleButton underline position

Additional Considerations

Links

WRQ-29377

Comments

Enact-DCO-1.0-Signed-off-by: Paul Beldean paul.beldean@lgepartner.com

Copy link

codecov bot commented Jul 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.88%. Comparing base (28acc99) to head (65a49b1).
Report is 2 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop     #806   +/-   ##
========================================
  Coverage    84.88%   84.88%           
========================================
  Files          120      120           
  Lines         4506     4506           
  Branches      1236     1237    +1     
========================================
  Hits          3825     3825           
  Misses         527      527           
  Partials       154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@daniel-stoian-lgp
Copy link
Contributor

please add changelog

Copy link
Contributor

@daniel-stoian-lgp daniel-stoian-lgp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check my comments

CHANGELOG.md Outdated Show resolved Hide resolved
Copy link
Contributor

@juwonjeong juwonjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@juwonjeong juwonjeong merged commit 14b00c0 into develop Aug 9, 2024
7 checks passed
@juwonjeong juwonjeong deleted the feature/WRQ-29377 branch August 9, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants