Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PLAT-40726 & ENYO-4798: Support babel-preset-env with dynamic targetted babel-polyfill usage #102

Merged
merged 8 commits into from
Oct 30, 2017

Conversation

JayCanuck
Copy link
Member

@JayCanuck JayCanuck commented Oct 10, 2017

  • Switched to a dynamic forward-compatible .babelrc.js configuration for babel. Once Babel 7 is release we can remove the additional static .babelrc.
  • Switched from babel-preset-es2015 to babel-preset-env using our target platform settings.
  • Removed babel-plugin-syntax-dynamic-import as it was already included within stage-0 preset.
  • Removed babel-plugin-transform-react-constant-elements due to known bugs. See Re-enable babel-plugin-transform-react-constant-elements when it’s not buggy facebook/create-react-app#553 for more details.
  • Uses a custom babel-loader cacheIdentifier which properly takes into account the target platforms.
  • Updated the polyfills to use babel-polyfill which will be expanded at buildtime to the specific polyfills required for the target platforms.

Enact-DCO-1.0-Signed-off-by: Jason Robitaille jason.robitaille@lge.com

@JayCanuck JayCanuck changed the title PLAT-40726: Support babel-preset-env with dynamic targetted babel-polyfill usage PLAT-40726 & ENYO-4798: Support babel-preset-env with dynamic targetted babel-polyfill usage Oct 10, 2017
Copy link
Contributor

@webOS101 webOS101 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@aarontam aarontam merged commit 53537aa into develop Oct 30, 2017
@aarontam aarontam deleted the feature/PLAT-40726 branch October 30, 2017 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants