Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRN-16706: POC for item reordering in VirtualList #1172

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

0x64
Copy link
Member

@0x64 0x64 commented Feb 24, 2022

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

POC for item reordering in VirtualList

Resolution

Added relocation logic

Additional Considerations

Links

WRN-16706
enactjs/enact#3016

Comments

Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
Enact-DCO-1.0-Signed-off-by: Seungcheon Baek (sc.baek@lge.com)
@codecov
Copy link

codecov bot commented Feb 24, 2022

Codecov Report

Merging #1172 (2e04b89) into develop (e998acb) will increase coverage by 0.98%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1172      +/-   ##
===========================================
+ Coverage    56.52%   57.50%   +0.98%     
===========================================
  Files          135      135              
  Lines         6224     6406     +182     
  Branches      1766     1854      +88     
===========================================
+ Hits          3518     3684     +166     
- Misses        2107     2116       +9     
- Partials       599      606       +7     
Impacted Files Coverage Δ
VirtualList/VirtualList.js 73.33% <ø> (ø)
Picker/Picker.js 94.59% <0.00%> (-1.06%) ⬇️
RangePicker/RangePicker.js 100.00% <0.00%> (ø)
internal/Picker/SpottablePicker.js 100.00% <0.00%> (ø)
internal/Picker/Picker.js 80.92% <0.00%> (+4.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e998acb...2e04b89. Read the comment docs.

@0x64 0x64 changed the title Poc/wrn 16706 WRN-16706: POC for item reordering in VirtualList Feb 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant