WRQ-17933: Add changelog for QHD support #1608
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
juwonjeong
approved these changes
May 13, 2024
CHANGELOG.md
Outdated
Comment on lines
11
to
14
| ### Added | ||
|
|
||
| - `QHD` (2560x1440) resolution | ||
|
|
There was a problem hiding this comment.
Please move Added to the line 7
There was a problem hiding this comment.
I moved "Added" to line 7 and changed sentence
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1608 +/- ##
========================================
Coverage 81.51% 81.51%
========================================
Files 148 148
Lines 6631 6631
Branches 1957 1957
========================================
Hits 5405 5405
Misses 933 933
Partials 293 293 ☔ View full report in Codecov by Sentry. |
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)
seunghoh
requested changes
May 13, 2024
| @@ -4,6 +4,10 @@ The following is a curated list of changes in the Enact sandstone module, newest | |||
|
|
|||
| ## [unreleased] | |||
|
|
|||
| ### Added | |||
|
|
|||
| - Support for QHD displays | |||
There was a problem hiding this comment.
Added sandstone/ThemeDecorator/screenTypes value qhd to support QHD displays
or
Added screenTypes value qhd to support QHD displays
seunghoh
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
QHD is supported in sandstone by this ticket #1599
We need to add CHANGELOG for sandstone QHD support
Resolution
I added CHANGELOG for sandstone QHD support
Additional Considerations
Links
WRQ-17933
Comments
Enact-DCO-1.0-Signed-off-by: Jiye Kim (jiye.kim@lge.com)