Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRQ-2288: Apply large screen mode to sampler #1618

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

mmyelyn
Copy link
Contributor

@mmyelyn mmyelyn commented May 23, 2024

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

There is a requirement for large screen mode(before large text) for a11y.
Since the purpose is to increase the screen magnification, the name large screen mode was used.

Resolution

Receives the screen scale value from global and applies it to the sampler.

Additional Considerations

Changed the way story is called. Decorator should be called first, followed by story.
refer to : storybookjs/storybook#11852

Links

WRQ-2288

Comments

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)

Enact-DCO-1.0-Signed-off-by: Hyelyn Kim (myelyn.kim@lge.com)
Copy link

codecov bot commented May 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.01%. Comparing base (612b167) to head (20f2a86).
Report is 37 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1618      +/-   ##
===========================================
+ Coverage    81.51%   82.01%   +0.50%     
===========================================
  Files          148      149       +1     
  Lines         6631     6871     +240     
  Branches      1957     2045      +88     
===========================================
+ Hits          5405     5635     +230     
- Misses         933      943      +10     
  Partials       293      293              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mmyelyn mmyelyn marked this pull request as draft July 5, 2024 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant