-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRN-12748: Update eslint 8 related modules in tool repos #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikyungKim
reviewed
Apr 1, 2022
MikyungKim
reviewed
Apr 1, 2022
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com>
MikyungKim
approved these changes
Apr 1, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:lgtm:
5 tasks
hong6316
added a commit
that referenced
this pull request
Jul 1, 2022
* WRN-12124: Remove deprecated babel-eslint module (#24) * use @babel/eslint-parser * Revert "use @babel/eslint-parser" This reverts commit dfc9555. * babel-eslint -> @babel/eslint-parser * modify changelog * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * remove unused package Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * revert shrinkwrap Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-12748: Update eslint 8 related modules in tool repos (#25) * update eslint 8 * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * added a changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * typo Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
0x64
pushed a commit
that referenced
this pull request
Sep 16, 2022
* WRO-614: Merge `feature/webpack5` branch (#30) * WRN-12124: Remove deprecated babel-eslint module (#24) * use @babel/eslint-parser * Revert "use @babel/eslint-parser" This reverts commit dfc9555. * babel-eslint -> @babel/eslint-parser * modify changelog * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * remove unused package Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * revert shrinkwrap Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * WRN-12748: Update eslint 8 related modules in tool repos (#25) * update eslint 8 * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * Update package.json Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> Co-authored-by: Mikyung Kim <mikyung27.kim@lge.com> * added a changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * typo Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com> * WRO-614: Migrate to storybook 6.5 and webpack5 (#31) * initial commit Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * Migrate to webpack5 Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies and changelog Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * fix travis fail Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * removed unnecessary change Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * update dependencies Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) * WRO-7575: Fix ContextualPopup is not showing properly with webpack5 (#32) Enact-DCO-1.0-Signed-off-by: Mikyung Kim (mikyung27.kim@lge.com) Co-authored-by: taeyoung.hong <35059065+hong6316@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Resolved / Feature Added
ESLint v8.0.0 is released 🎉
Dependencies should be compatible with ESLint 8 too
Resolution
update eslint 8 & related modules
Additional Considerations
※ BEFORE THIS CHANGE, UPDATE & RELEASE WRN-12124 FIRST.
Links
WRN-12748
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)