Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WRP-6904: Remove eslint-related modules #54

Merged
merged 4 commits into from
Jun 22, 2023

Conversation

hong6316
Copy link
Contributor

@hong6316 hong6316 commented Jun 14, 2023

Checklist

  • I have read and understand the contribution guide
  • A CHANGELOG entry is included
  • At least one test case is included for this feature or bug fix
  • Documentation was added or is not needed
  • This is an API breaking change

Issue Resolved / Feature Added

Previously, there were attempts to install each eslint-related module in one repo(ex: eslint-config-enact) so that each tooling (dev-utils, cli, storybook-utils, ui-test-utils) does not install additional eslint-related modules.
The installation of eslint-config-enact alone did not install the necessary eslint-related modules, so it had to be managed separately, and the reason was not known.
This patch is a workaround for a longstanding eslint/eslint#3458 that would allow a shared ESLint config to bring along its own plugins, rather than imposing peer dependencies on every consumer of the config.
Doing so greatly reduces the copy+pasting and version management for all the other projects that use your standard lint rule set, but don't want to be bothered with the details.

References

Resolution

Remove eslint-related modules and apply enactjs/eslint-config-enact#66

Additional Considerations

We can remove eslint-related modules after release enactjs/eslint-config-enact#66

Links

WRP-6904

Comments

Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)

@hong6316 hong6316 changed the title WRP-6904: Move eslint-related modules to peerDependencies WRP-6904: Remove eslint-related modules Jun 16, 2023
Copy link
Contributor

@sjro sjro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjro sjro merged commit d6bf2bd into feature/unify-eslint-modules Jun 22, 2023
@sjro sjro deleted the feature/WRP-6904 branch June 22, 2023 07:53
sjro pushed a commit that referenced this pull request Jan 4, 2024
…nch (#68)

* WRP-6904: Remove eslint-related modules (#54)

* Move eslint-related modules to peerDependencies

* use @rushstack/eslint-patch

* remove eslint-related modules

* update CHANGELOG.md

* apply eslint-config-enact 4.2.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants