WRP-6904: Remove eslint-related modules #54
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Issue Resolved / Feature Added
Previously, there were attempts to install each eslint-related module in one repo(ex: eslint-config-enact) so that each tooling (dev-utils, cli, storybook-utils, ui-test-utils) does not install additional eslint-related modules.
The installation of eslint-config-enact alone did not install the necessary eslint-related modules, so it had to be managed separately, and the reason was not known.
This patch is a workaround for a longstanding eslint/eslint#3458 that would allow a shared ESLint config to bring along its own plugins, rather than imposing peer dependencies on every consumer of the config.
Doing so greatly reduces the copy+pasting and version management for all the other projects that use your standard lint rule set, but don't want to be bothered with the details.
References
Resolution
Remove eslint-related modules and apply enactjs/eslint-config-enact#66
Additional Considerations
We can remove eslint-related modules after release enactjs/eslint-config-enact#66
Links
WRP-6904
Comments
Enact-DCO-1.0-Signed-off-by: Taeyoung Hong (taeyoung.hong@lge.com)