Add impl TryFrom<&[u8; 48]> for QuoteHeader #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lkatalin
force-pushed
the
quoteheader
branch
from
21298d9
to
e1df6dd
Compare
connorkuehl
suggested changes
Dec 16, 2020
|
@connorkuehl Yeah, sure! I'll push a new version. |
lkatalin
force-pushed
the
quoteheader
branch
from
e1df6dd
to
b3b3c28
Compare
1 task
|
Should the module structure be: |
lkatalin
force-pushed
the
quoteheader
branch
2 times, most recently
from
f5ee144
to
91041ec
Compare
This breaks quote.rs into smaller submodules quote.rs, quoteheader.rs, and sigdata.rs. Signed-off-by: Lily Sturmann <lsturman@redhat.com>
Signed-off-by: Lily Sturmann <lsturman@redhat.com>
lkatalin
force-pushed
the
quoteheader
branch
from
91041ec
to
239cc07
Compare
@connorkuehl That is an extremely reasonable suggestion. Updated. |
haraldh
approved these changes
Dec 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has
Quotetype into submodules (includes a few small fixes)impl TryFrom<&[u8; 48]> for QuoteHeaderThe former involved some reorganization of the code inquote.rsto be more organized, ex. the types now show up in the order that they go into theQuote. There are also header comments to help delineate these different sections. Alternatively, I could break these parts out into small submodules in separate files. Any thoughts on this?Edit: there are now submodules for
quote.Related to: enarx/enarx#917 ,
Related to: enarx/enarx#84