Support options.requires fallback for backward compatibility #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miripiruni
reviewed
Nov 17, 2017
techs/bem-xjst.js
Outdated
| 'enb-bemxjst', this.getName(), 'requires', 'engineOptions.requires', | ||
| ' It will be removed in v9.0.0.'); | ||
| } | ||
| engineOptions.requires || (engineOptions.requires = this._requires); |
There was a problem hiding this comment.
better place for the line is between 136 and 137 =)
miripiruni
reviewed
Nov 17, 2017
techs/bem-xjst.js
Outdated
| if (this._requires) { | ||
| this.node.getLogger().logOptionIsDeprecated(this.node.unmaskTargetName(this._target), | ||
| 'enb-bemxjst', this.getName(), 'requires', 'engineOptions.requires', | ||
| ' It will be removed in v9.0.0.'); |
There was a problem hiding this comment.
How not to forget about it when releasing a v9.0.0?
tadatuta
force-pushed
the
issues/285.requires.tadatuta
branch
from
73f9683
to
00a8f02
Compare
|
🆙 |
miripiruni
requested changes
Nov 17, 2017
There was a problem hiding this comment.
-
test "must pass engineOptions.engineName to bem-xjst"
-
test "must pass engineOptions.requires to bem-xjst"
…and maybe we can extract describe "engineOptions" here https://github.com/enb/enb-bemxjst/blob/master/test/techs/bemhtml.test.js#L165
miripiruni
force-pushed
the
issues/285.requires.tadatuta
branch
from
00a8f02
to
dffa460
Compare
miripiruni
approved these changes
Feb 12, 2018
miripiruni
force-pushed
the
issues/285.requires.tadatuta
branch
3 times, most recently
from
eb420ad
to
a128856
Compare
* Describes renamed: according to options and tests group * iife test added * dublicate tests removed
miripiruni
force-pushed
the
issues/285.requires.tadatuta
branch
from
09eff3e
to
1552380
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.