-
-
Notifications
You must be signed in to change notification settings - Fork 7k
Add HStoreField, postgres fields tests #5654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! 💃🏼
@rpkilby Why did you mark this for 3.8? |
It seemed appropriate to include it with the other composite field changes. But it's not a strong opinion. |
Oh, right - completely forgot. Django 1.10 does not support null values in |
Django 1.10 doesn't fail outright - it just saves null values as strings, which is a subtly wrong change in behavior. |
Hmm. OK. I can't quite see why the test is passing then... 🙂 |
... because I'm conflating the two fields. (Ours and Fine. Let's have this as is. |
The test is passing since it's just serializer validation. Nothing is actually being written to the DB. A failing test would look like:
|
* Test postgres field mapping * Add HStoreField * Ensure 'HStoreField' child is a 'CharField' * Add HStoreField docs
Fixes #5644
HStoreField
HStoreField
acceptsnull
values by default