-
-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document support for http.HTTPMethod in the @action decorator added in Python 3.11. #9067
Conversation
641b8b0
to
a294a45
Compare
a294a45
to
e1119f2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
my thoughts on this is, do django support this structs as of yet?
That is a very good question. I have not found any use of >>> HTTPMethod.GET == "GET"
True So I think we can say yes, Django supports |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm still reluctant to at this right now before knowing the decisions of other maintainers
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This pull request ensures that the
http.HTTPMethod
added in Python 3.11 is fully supported in the@action
decorator, as mentioned in issue #8995.Description
Only one test and documentation update is needed, since
http.HTTPMethod
already functions as is.The reason for this is that
@action
already invokeslower()
on eachmethod
, which convertshttp.HTTPMethod
to astr
a format that is already supported.