Local address support #134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are failing with an IPv6 address and asyncio. Not sure why yet.
| assert http_version == b"HTTP/1.1" | ||
| assert status_code == 200 | ||
| assert reason == b"OK" | ||
| assert len(http._connections[url[:3]]) == 1 # type: ignore |
There was a problem hiding this comment.
It doesn't look like this test tests that the local_address actually gets used — I suppose that's intended for simplicity since testing that w/o mocking is not trivial?
florimondmanca
approved these changes
Aug 5, 2020
Co-authored-by: Florimond Manca <florimond.manca@gmail.com>
…into bwelling-master
|
@florimondmanca Fantastic review points as always - thank you! |
This was referenced Sep 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #100 with a few extra minor changes.
local_addressas the keyword argument name. (If in doubt, follow the Trio API.)stras the argument type. (Granted we're usingbytesthroughtout in ourrequest()API, but I'm not sure I see the point in that here - all the underlying backends either expect or allow the address as a string. If in doubt, follow the Trio API.)local_address=...on Trio. (currently only usable against trio master branch)open_tcp_stream()