Tweak get_connection_info()
and keepalive_expiry
behaviour.
#137
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes here...
Instead becomes...
This is important because it allows us to run a keep-alive expiry sweep before returning the connection info, so you'll be seeing more valid information.
Secondly, we were previously capping our keep-alive expiry checks to at most once per second. Now if
keepalive_expiry
is set, and is less than 1.0, then we'll check for expiry more frequently than once per second. In particular this ensures thatkeepalive_expiry=0.0
functions as expected.Note that
.get_connection_info()
is only introduced from 0.10 onwards, so this is an addition, not a breaking change.