Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "trailing_headers" extension for HTTP/1.1 #582

Closed
wants to merge 8 commits into from

Conversation

tomchristie
Copy link
Member

See encode/httpx#1149

Adding support in HTTP/2 should be similar, requiring the h2.TrailersReceived event to populate any trailing headers.

https://python-hyper.org/projects/h2/en/stable/api.html#h2.events.TrailersReceived

@tomchristie tomchristie added the enhancement New feature or request label Sep 29, 2022
Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's no mention about the TE headers. Is it intended? 🤔

docs/extensions.md Show resolved Hide resolved
Co-authored-by: Marcelo Trylesinski <marcelotryle@gmail.com>
@tomchristie
Copy link
Member Author

Ah gotcha... I see that now yes. The presence of a TE header on the request doesn't matter to h11...

The other headers in RFC 7230 are TE:, Trailer:, and Via:; h11 also supports these in the sense that it ignores them and that’s really all it should be doing.

But yes, it makes sense to include it in the example.

It'd be really nice to have a real URL we can point at for this one. 🤣

@tomchristie
Copy link
Member Author

Right. Needs a CONNECT and/or Upgrade test case to bump the coverage back to 100%

@tomchristie tomchristie closed this Nov 7, 2022
@tomchristie tomchristie deleted the http11-trailing-headers-support branch November 7, 2022 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants